https://bugzilla.redhat.com/show_bug.cgi?id=2196603
--- Comment #4 from Benson Muite benson_muite@emailplus.org --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues: ======= - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 8366080 bytes in 557 files. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_documentation
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* MIT License", "*No copyright* [generated file]". 500 files have unknown license. Detailed output of licensecheck in /home/FedoraPackaging/reviews/zydis/2196603-zydis/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib64/cmake/zydis [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib64/cmake/zydis [ ]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in zydis- devel , zydis-tools [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 8468480 bytes in /usr/share [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: zydis-4.0.0-1.fc38.x86_64.rpm zydis-devel-4.0.0-1.fc38.x86_64.rpm zydis-tools-4.0.0-1.fc38.x86_64.rpm zydis-debuginfo-4.0.0-1.fc38.x86_64.rpm zydis-debugsource-4.0.0-1.fc38.x86_64.rpm zydis-4.0.0-1.fc38.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpd3m4boqy')] checks: 31, packages: 6
zydis.x86_64: W: no-documentation zydis-devel.x86_64: W: files-duplicate /usr/share/doc/Zydis/api/search/variables_0.js /usr/share/doc/Zydis/api/search/all_0.js zydis-devel.x86_64: W: files-duplicate /usr/share/doc/Zydis/api/search/variables_1.js /usr/share/doc/Zydis/api/search/all_1.js zydis-devel.x86_64: W: files-duplicate /usr/share/doc/Zydis/api/search/variables_10.js /usr/share/doc/Zydis/api/search/all_10.js zydis-devel.x86_64: W: files-duplicate /usr/share/doc/Zydis/api/search/variables_13.js /usr/share/doc/Zydis/api/search/all_13.js zydis-devel.x86_64: W: files-duplicate /usr/share/doc/Zydis/api/search/variables_14.js /usr/share/doc/Zydis/api/search/all_14.js zydis-devel.x86_64: W: files-duplicate /usr/share/doc/Zydis/api/search/variables_6.js /usr/share/doc/Zydis/api/search/all_6.js zydis-devel.x86_64: W: files-duplicate /usr/share/doc/Zydis/api/search/variables_8.js /usr/share/doc/Zydis/api/search/all_8.js zydis-devel.x86_64: W: files-duplicate /usr/share/doc/Zydis/api/search/variables_9.js /usr/share/doc/Zydis/api/search/all_9.js zydis-devel.x86_64: W: files-duplicate /usr/share/doc/Zydis/api/search/variables_b.js /usr/share/doc/Zydis/api/search/all_b.js zydis-devel.x86_64: W: files-duplicate /usr/share/doc/Zydis/api/search/variables_c.js /usr/share/doc/Zydis/api/search/all_c.js zydis-devel.x86_64: W: files-duplicate /usr/share/doc/Zydis/api/search/variables_d.js /usr/share/doc/Zydis/api/search/all_d.js 6 packages and 0 specfiles checked; 0 errors, 12 warnings, 0 badness; has taken 4.3 s
Rpmlint (debuginfo) ------------------- Checking: zydis-tools-debuginfo-4.0.0-1.fc38.x86_64.rpm zydis-debuginfo-4.0.0-1.fc38.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpubwd6c5p')] checks: 31, packages: 2
2 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.9 s
Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 6
zydis.x86_64: W: no-documentation zydis-devel.x86_64: W: files-duplicate /usr/share/doc/Zydis/api/search/variables_0.js /usr/share/doc/Zydis/api/search/all_0.js zydis-devel.x86_64: W: files-duplicate /usr/share/doc/Zydis/api/search/variables_1.js /usr/share/doc/Zydis/api/search/all_1.js zydis-devel.x86_64: W: files-duplicate /usr/share/doc/Zydis/api/search/variables_10.js /usr/share/doc/Zydis/api/search/all_10.js zydis-devel.x86_64: W: files-duplicate /usr/share/doc/Zydis/api/search/variables_13.js /usr/share/doc/Zydis/api/search/all_13.js zydis-devel.x86_64: W: files-duplicate /usr/share/doc/Zydis/api/search/variables_14.js /usr/share/doc/Zydis/api/search/all_14.js zydis-devel.x86_64: W: files-duplicate /usr/share/doc/Zydis/api/search/variables_6.js /usr/share/doc/Zydis/api/search/all_6.js zydis-devel.x86_64: W: files-duplicate /usr/share/doc/Zydis/api/search/variables_8.js /usr/share/doc/Zydis/api/search/all_8.js zydis-devel.x86_64: W: files-duplicate /usr/share/doc/Zydis/api/search/variables_9.js /usr/share/doc/Zydis/api/search/all_9.js zydis-devel.x86_64: W: files-duplicate /usr/share/doc/Zydis/api/search/variables_b.js /usr/share/doc/Zydis/api/search/all_b.js zydis-devel.x86_64: W: files-duplicate /usr/share/doc/Zydis/api/search/variables_c.js /usr/share/doc/Zydis/api/search/all_c.js zydis-devel.x86_64: W: files-duplicate /usr/share/doc/Zydis/api/search/variables_d.js /usr/share/doc/Zydis/api/search/all_d.js 6 packages and 0 specfiles checked; 0 errors, 12 warnings, 0 badness; has taken 7.0 s
Source checksums ---------------- https://github.com/zyantific/zydis/archive/v4.0.0/zydis-4.0.0.tar.gz : CHECKSUM(SHA256) this package : 14e991fd97b021e15c77a4726a0ae8a4196d6521ab505acb5c51fc2f9be9530a CHECKSUM(SHA256) upstream package : 14e991fd97b021e15c77a4726a0ae8a4196d6521ab505acb5c51fc2f9be9530a
Requires -------- zydis (rpmlib, GLIBC filtered): libc.so.6()(64bit) rtld(GNU_HASH)
zydis-devel (rpmlib, GLIBC filtered): cmake-filesystem(x86-64) libZydis.so.4.0()(64bit) zydis(x86-64)
zydis-tools (rpmlib, GLIBC filtered): libZycore.so.1.4()(64bit) libZydis.so.4.0()(64bit) libc.so.6()(64bit) rtld(GNU_HASH) zydis(x86-64)
zydis-debuginfo (rpmlib, GLIBC filtered):
zydis-debugsource (rpmlib, GLIBC filtered):
Provides -------- zydis: libZydis.so.4.0()(64bit) zydis zydis(x86-64)
zydis-devel: cmake(zydis) zydis-devel zydis-devel(x86-64)
zydis-tools: zydis-tools zydis-tools(x86-64)
zydis-debuginfo: debuginfo(build-id) libZydis.so.4.0.0.0-4.0.0-1.fc38.x86_64.debug()(64bit) zydis-debuginfo zydis-debuginfo(x86-64)
zydis-debugsource: zydis-debugsource zydis-debugsource(x86-64)
Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -b 2196603 -m fedora-38-x86_64 Buildroot used: fedora-38-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Python, PHP, Perl, Haskell, R, fonts, Ocaml, Ruby, Java, SugarActivity Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Comments: a) No need to include gz extension in man files b) Consider packaging the examples c) HTML documentation should be in a separate sub-package, it is quite large d) Consider generating man pages as well e) Add a line %dir %{_libdir}/cmake/zydis to the spec to ensure this directory is owned by this package