Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xpa
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195015
michael@knox.net.nz changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bugzilla-sink@leemhuis.info |michael@knox.net.nz OtherBugsDependingO|163776 |163778 nThis| |
------- Additional Comments From michael@knox.net.nz 2006-06-17 04:24 EST ------- * RPM name is OK * Source xpa-2.1.6.tar.gz is the same as upstream * This is the latest version * Builds fine in mock * rpmlint of xpa-devel looks OK * rpmlint of xpa looks OK * File list of xpa-devel looks OK * File list of xpa looks OK
I would recommend you just add some white space between the %package devel and %description devel. Same again for %install and %clean, just improves the flow and readability of your spec file.
If you make those changes, I see no reason why I can't approve this package.