Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: R-Matrix - R module, Classes etc. for dense and sparse matrices and matrix ops
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241052
tcallawa@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |tcallawa@redhat.com Flag| |fedora-review+
------- Additional Comments From tcallawa@redhat.com 2007-05-25 12:32 EST ------- There is a very minor issue with this package, but it doesn't hold up approval.
- rpmlint says you've got mixed spaces and tabs, look at line 29.
Fix that item before requesting builds, and we're good. Nice work with the -devel package.
Good:
- rpmlint checks return:
W: R-Matrix mixed-use-of-spaces-and-tabs (spaces: line 29, tab: line 5) W: R-Matrix-devel no-documentation E: R-Matrix-devel only-non-binary-in-usr-lib
Safe to ignore the Error (all R packages do that), and the no-docs in -devel.
- package meets naming guidelines - package meets packaging guidelines - license (Distributable) OK, text in package, matches source (code is a mix of MIT, GPL, LGPL, documented in spec) - spec file legible, in am. english - source matches upstream - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file - devel package ok - no .la files
APPROVED. I'll also sponsor you, thanks for your good work.