Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=498193
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #3 from Parag AN(पराग) panemade@gmail.com 2009-04-30 04:40:26 EDT --- Review: + package builds in mock (rawhide i586). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1329843 + rpmlint is silent for SRPM and for RPM. + source files match upstream url bc428af291b36b1c0ffa1e5c96408f72 ExtUtils-InferConfig-1.03.tar.gz
+ package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=4, Tests=2213, 2 wallclock secs ( 0.45 usr 0.03 sys + 1.45 cusr 0.09 csys = 2.02 CPU) + Package perl-ExtUtils-InferConfig-1.03-2.fc12.noarch => Provides: perl(ExtUtils::InferConfig) = 1.03 Requires: perl(Carp) perl(Config) perl(IPC::Cmd) perl(strict) perl(vars) + Not a GUI application
APPROVED.