Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: grib_api - ECMWF encoding/decoding GRIB software
https://bugzilla.redhat.com/show_bug.cgi?id=427121
------- Additional Comments From pertusus@free.fr 2008-03-02 16:29 EST ------- (In reply to comment #3)
This all looks good to me. I guess the bad test could be troublesome but if you don't have a problem with then I won't worry about it.
According to upstream it is fixed, but upstream also asked me to wait for the next release to make a release.
I guess if you're not going to need the commented-out scriptlets you could remove them so the spec looks cleaner, but that's really minor.
I am discussing adding shared libs with the debian maintainer (upstream agreed), so I'll prefer to keep them.
Which name did you think was too generic? I guess "typesizes.mod" might be, but I don't know how many .mod files we're going to end up seeing. Everything else seemed to me to be prefixed, in a subdirectory or simply named such that conflicts would be improbable.
It is because I prefixed 2 of them... .mod files should really not be generic, I hope that we end up with a lof of .mod files...
Thanks for the review!
New Package CVS Request ======================= Package Name: grib_api Short Description: ECMWF encoding/decoding GRIB software Owners: pertusus Branches: InitialCC: Cvsextras Commits: yes