https://bugzilla.redhat.com/show_bug.cgi?id=2351398
Jerry James loganjerry@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #22 from Jerry James loganjerry@gmail.com --- That looks pretty good. Just a couple more items.
To require an architecture-specific package from a noarch package, just omit "%{?_isa}". In this case, the workrave-cinnamon package would have these lines:
Requires: %{name} = %{version}-%{release} BuildArch: noarch
In "%files mate", there are two lines: %{_datadir}/mate-panel/ui %{_datadir}/mate-panel/ui/workrave-menu.xml
The first includes the entire ui directory, including workrave-menu.xml, so rpmbuild now warns that workrave-menu.xml is listed twice. You should either remove the second line, or add %dir to the first line.
These are both very simple changes that I trust you to make when you import the package. This package is APPROVED.