[Bug 229319] Review Request: dekorator - KDE window decoration engine

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dekorator - KDE window decoration engine

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229319

------- Additional Comments From [e-mail]  2007-02-20 13:51 EST -------
#001: You should explicitly require kdebase, since this package is useless
without kwin.
Requires:      kdebase

#002: other themes ??

On kcontrol, if I select dekorator, then Help, I see
****** In the package ******
deKorator comes with:
    * default-theme - Used by default, illustrates some of deKorator's
      features.
    * ugly-theme - It's purpose is to understand the way deKorator paints the
      decorations.
    * template-theme - this theme  is meant to be a template theme for other
themes,this theme features all possible buttons.
    * Bushido-Yellow-theme - shows how masking can be done.

But your package is only shipping 2 themes:
- default-theme and
- template-theme

#003: Below that same page (help), there is a typo "Allways", it should be
Always. Patch as appropriate and inform upstream.

#004: Is there any reason why you are shipping ugly-theme.tar.gz at
/usr/share/doc/dekorator-0.3/themes/ ?

#005 I've also noticed that /usr/share/doc/dekorator-0.3/themes/deKhelp.xhtml is
a duplicate to the "help" page provided by the kcontrol module.

#006: For the very first time, one select and use dekorator, he/she will be
frameless. Users will freak out. Can you do the necessary so that a default
theme might be chosen by default.