https://bugzilla.redhat.com/show_bug.cgi?id=1873373
--- Comment #1 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- - This is not used in Fedora:
Group: Development/Debuggers
- The link to the archive is not valid:
Source: https://github.com/crash-utility/crash-extensions/raw/master/%%7Bname%7D-%%7...
Also uploading binary archive straight to git is a bad idea. It would be better to tag a release. Everyone cloning the repo wall have to download the binary even if you delete it later. It could be purged from history but I don't know the exact procedure.
- Not needed:
ExclusiveOS: Linux
- ExclusiveArch: x86_64 %{ix86} arm aarch64 ppc64 ppc64le → ExclusiveArch: x86_64 %{ix86} %{arm} aarch64 ppc64 ppc64le
- Split your BR one per line, consider using pkgconfig() for your devel dependency:
BuildRequires: crash-devel >= 5.1.5 BuildRequires: pkgconfig(zlib) BuildRequires: pkgconfig(lzo2) BuildRequires: pkgconfig(snappy)
- Not needed:
rm -Rf $RPM_BUILD_ROO
%clean rm -rf %{buildroot} rm -Rf $RPM_BUILD_ROOT
%defattr(-,root,root)
- License file must be installed with %license not %doc
%license COPYING
- You need to make sure Fedora build flags are used for the build.
Use %set_build_flags to set them up.
%build %set_build_flags %make_build -f gcore.mk
- make -f gcore.mk → %make_build -f gcore.mk
- please use install to create and install file at the right place:
install -m 0755 -vd %{buildroot}%{_libdir}/crash/extensions/ install -m 0755 -vp gcore.so %{buildroot}%{_libdir}/crash/extensions/