https://bugzilla.redhat.com/show_bug.cgi?id=1246792
Ralf Corsepius rc040203@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |rc040203@freenet.de
--- Comment #19 from Ralf Corsepius rc040203@freenet.de --- Some remarks on your spec:
* I do not consider these defines useful: %define lname ndctl-libs %define dname ndctl-devel IMO, all they do is to reduce readability.
* %define should not be used in new specs anymore (Use %global instead).
* Except if you want to support very outdated distros (IIRC, < rhel5), %defattr(-,root,root) is not necessary, anymore and should not be used in specs anymore.
* github supports downloading tarballs. Consider to change Source0: into https://github.com/pmem/ndctl/archive/v50.tar.gz#/ndctl-0.50.tar.gz and to remove your make-git-shapshot.sh scripts.
* Append --disable-silent-rules %configure to make building verbose.