Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=544384
Michael Schwendt mschwendt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mschwendt@gmail.com
--- Comment #2 from Michael Schwendt mschwendt@gmail.com 2009-12-05 06:45:24 EDT ---
Name: report
This ought to adhere to Fedora's Package Naming Guidelines for Python modules:
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Addon_Packages_.28...
Summary: Incident reporting library
Actually, the terminology for this software would be "module" not "library". Mentioning that it's for Python would be good, too. Perhaps:
Summary: Python module for submitting reports to ticketing systems
Group: System Environment/Base
Group "Development/Languages" sounds more appropriate, certainly for all (sub-)packages that don't include any ready-to-use executable. The RPM Group is independent from the comps @base group.
License: GPLv2+
That's a blocker. Nothing in the source tarball (except the .spec.in) confirms this licensing. Please include the GNU GPL license text, and as an added benefit follow its guidelines (consult its appendix) by adding brief GPL headers to the source files.
%description plugin-catcut Plugin reporter to catcut
Odd. Too brief. At least the description could try to explain what "catcut" means in this context.
Source0: report-0.4.tar.gz
https://fedoraproject.org/wiki/Packaging/SourceURL
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
Specifying this is not necessary anymore with Fedora >= 10.
%install rm -rf $RPM_BUILD_ROOT
Empyting the buildroot is done by default with Fedora >= 10.
%clean rm -rf $RPM_BUILD_ROOT
There is a default %clean section with Fedora >= 10.
Requires: report == 0.4
Consider yourself lucky that this worked. Prefer '=' instead of '=='.
%files ... %attr(0664,root,root) %config(noreplace) /etc/catcut.config
Why is this package included in the base module package instead of the -catcut subackage?
%dir %{python_sitelib}/report/alternatives/redhat_bugzilla %{python_sitelib}/report/alternatives/redhat_bugzilla/*
Wherever you do the two-line %dir plus '*' wildcard dance you could simply use a single line instead, which achieves exactly the same thing and includes the directory and all its contents recursively:
%{python_sitelib}/report/alternatives/redhat_bugzilla/
-rw-rw-r-- /etc/catcut.config
g+w isn't really needed here. Nit-picky, I know. ;)