Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=466147
Stefan Posdzich cheekyboinc@foresightlinux.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |cheekyboinc@foresightlinux. | |org Flag| |fedora-review+
--- Comment #8 from Stefan Posdzich cheekyboinc@foresightlinux.org 2009-02-18 16:11:07 EDT --- ++ REVIEW ++
MUST: rpmlint output | GOOD
rpmlint fedora-ksplice-0.5-1.fc10.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
rpmlint fedora-ksplice-0.5-1.fc10.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
MUST: package must be named according to Package Naming Guidelines | GOOD
MUST: The spec file name must match the base package | GOOD
MUST: The package must meet the Packaging Guidelines | GOOD
MUST: licensed with a Fedora approved license | GOOD
License: GPLv3
MUST: License field must match the actual license | GOOD
MUST: Docs (with license) | GOOD
AUTHORS COPYING README
MUST: The spec file must be written in American English | GOOD
MUST: The spec file for the package MUST be legible | GOOD
MUST: md5sum | GOOD
src.rpm: 8b6a7bbc5a1d14bd53b62fd405056fc2 fedora-ksplice-0.5.tar.gz upstream: 8b6a7bbc5a1d14bd53b62fd405056fc2 fedora-ksplice-0.5.tar.gz
MUST: compile and build on at least one primary architecture. | GOOD
http://koji.fedoraproject.org/koji/taskinfo?taskID=1136624
MUST: All build dependencies must be listed in BuildRequires | GOOD
MUST: not contain any duplicate files in the %files listing | GOOD
MUST: Permissions on files must be set properly | GOOD
MUST: Package is working | GOOD
APPROVED