Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: HippoDraw - Interactive and Python scriptable data analysis application
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208034
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-03-27 05:59 EST ------- (In reply to comment #39)
(In reply to comment #37)
Among them, some header files have #ifdef judgments for HAVE_MINUIT2, HAVE_NUMARRAY, BOOST_DEFECT. Would you check if all of the ifdef check for these values are of no problem?
I haven't checked the package, but in general there should never be such conditionals in the API. Is there something special in that package?
I agree. Generally header files included in -devel package should not have #ifdef conditionals like above.. This usually causes API breakage, and may cause problems when other applications want to use these header files with some macros re-defined.
(In reply to comment #38)
There are a number of #ifdef with macros of the from HAVE_xxx. All are defined in config.h. What was misssing, I think, is installation of the config.h file itself. That is now fixed in the upstream sources.
However, having header files created by autotools included as -devel header files are generally considered as BAD ( see the explanation by Michael Schwendt and Hans de Goede on bug 232342 ).