Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=885120
Jos de Kloe josdekloe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |josdekloe@gmail.com
--- Comment #1 from Jos de Kloe josdekloe@gmail.com --- the package builds fine using mock with target rawhide as well on my side, and produces 3 rpms. The rpmlint results on these are:
rpmlint python-elfdata-0.2-1.fc19.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
rpmlint python-elfdata-0.2-1.fc19.x86_64.rpm
python-elfdata.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/si\ te-packages/elfdata.so 0775L 1 packages and 0 specfiles checked; 1 errors, 0 warnings.
rpmlint python-elfdata-debuginfo-0.2-1.fc19.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
the software seems to work correct:
at the python prompt:
import elfdata elfdata.get_buildid('/usr/bin/python')
['581d0eca14f240d039dea75937520809a6f02cfc']
gives the same buildid result as issuing eu-readelf -n /usr/bin/python on the commandline.
eu-readelf -n /usr/bin/python | tail -1
Build ID: 581d0eca14f240d039dea75937520809a6f02cfc
My main complaint for this module is the lack of documentation. (usage of the module may be obvious for those deeply involved into elf, but it wasn't for me). This is not directly related to the packaging, but since you are the author as well I have to mention it.
The only 3 lines of documentation in the doc string of the module after issuing help(elfdata) on the python prompt are:
FUNCTIONS get_buildid(...) Does some magic
adding some more documentation would make this module much more usefull to actual users I think.