https://bugzilla.redhat.com/show_bug.cgi?id=2184588
Felix Wang topazus@outlook.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |topazus@outlook.com
--- Comment #19 from Felix Wang topazus@outlook.com --- I see that no assignee at the moment. I take this. You corrected the things that Miro Hrončok said, most of the package seems good to me. As for license issue, I read the documentation again, it said
If the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %license.
Since it says 'must be included in %license', so you are right. The additional packaging of license file using %license will be all right, although %pyproject_save_files macro includes the license file. Apologized for my previous misunderstanding,which may give inconvenience to you.
But I note that some python-related packages does not use %license (put license under /usr/share/licenses), like python3-pytest, python3-virtualenv.
ref: https://packages.fedoraproject.org/pkgs/pytest/python3-pytest/fedora-rawhide... https://packages.fedoraproject.org/pkgs/python-virtualenv/python3-virtualenv...
Finally, I approved the package.