https://bugzilla.redhat.com/show_bug.cgi?id=2217892
--- Comment #7 from zzambers@redhat.com --- Thank you for review. I have updated package:
Spec URL: https://download.copr.fedorainfracloud.org/results/zzambers/fedora-pkgs/fedo... SRPM URL: https://download.copr.fedorainfracloud.org/results/zzambers/fedora-pkgs/fedo...
Sorry for that delay, only now got to that. Changes: [1]
Fixed: - license files use %license - License name fixed to valid SPDX and added comment - removed jpackage-utils dependency from javadoc pacakge - both patches now use -p1 and make use of %autopatch (%autosetup did not work because it expected ant-contrib-1.0 dir in unpacked source rather than ant-contrib) - find commands removing binaries simplified - added -p to cp command - fixed typo in word "deprecated" in changelog
Kept: - compilation warnings (I kept this for a time being, I can fix that later, if it becomes a problem) - non-conffile-in-etc: %{_sysconfdir}/ant.d/ant-contrib - this is not really config file for user to edit, but rather a way to registers ant-contrib to ant [2], so I have not marked it as config (btw. apache-ivy does the same [3])
[1] https://src.fedoraproject.org/fork/zzambers/rpms/ant-contrib/c/629172303a007... [2] https://stackoverflow.com/a/2949734 [3] https://src.fedoraproject.org/rpms/apache-ivy/blob/85df0ca27e1264a173a0eb7e2...