https://bugzilla.redhat.com/show_bug.cgi?id=1366028
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |zbyszek@in.waw.pl Assignee|nobody@fedoraproject.org |zbyszek@in.waw.pl Flags| |fedora-review+
--- Comment #1 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- rpmlint says: python2-flask-migrate.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/flask_migrate/templates/flask-multidb/env.py python2-flask-migrate.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/flask_migrate/templates/flask-multidb/script.py.mako python2-flask-migrate.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/flask_migrate/templates/flask/env.py python2-flask-migrate.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/flask_migrate/templates/flask-multidb/README python2-flask-migrate.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/flask_migrate/templates/flask/script.py.mako python2-flask-migrate.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/flask_migrate/templates/flask/README python3-flask-migrate.noarch: E: script-without-shebang /usr/lib/python3.5/site-packages/flask_migrate/templates/flask/README python3-flask-migrate.noarch: E: script-without-shebang /usr/lib/python3.5/site-packages/flask_migrate/templates/flask-multidb/script.py.mako python3-flask-migrate.noarch: E: script-without-shebang /usr/lib/python3.5/site-packages/flask_migrate/templates/flask-multidb/README python3-flask-migrate.noarch: E: script-without-shebang /usr/lib/python3.5/site-packages/flask_migrate/templates/flask-multidb/env.py python3-flask-migrate.noarch: E: script-without-shebang /usr/lib/python3.5/site-packages/flask_migrate/templates/flask/script.py.mako python3-flask-migrate.noarch: E: script-without-shebang /usr/lib/python3.5/site-packages/flask_migrate/templates/flask/env.py
→ please chmod
python-flask-migrate.src:89: W: macro-in-comment %check python-flask-migrate.src:90: W: macro-in-comment %{__python2} python-flask-migrate.src:92: W: macro-in-comment %{__python3} python-flask-migrate.src:93: W: macro-in-comment %endif
%sum macro is not needed, just use Summary: normally the first time, and then Summary: %{summary} in the subsequent ones.
You don't need to remove .egg-info, this guideline has been rescinded.
%description could be extended a bit.
+ package name is OK + license is acceptable (MIT) + license is specified correctly + latest version + modern python template is used + %python_provide is used + build/requires/BR look OK + no scriptlets necessary + fedora-review is happy + rpmlint output above, please fix the issues
Package is APPROVED.