https://bugzilla.redhat.com/show_bug.cgi?id=2358970
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |decathorpe@gmail.com CC| |decathorpe@gmail.com Flags| |fedora-review?
--- Comment #11 from Fabio Valentini decathorpe@gmail.com --- Some issues in the package as-is:
# * - dynamic::type_sizes This test uses std::mem::size_of which is inconsistent # on i686
This might be indicative of a real problem (or not), would be good to check with upstream.
LICENSE-APACHE LICENSE-MIT
These files don't contain actual license texts, but the literal strings "../LICENSE-APACHE" and "../LICENSE-MIT", respectively.
Looks like the current version was published on a Windows system without working symbolic links (or the files are actually messed up in git too, I haven't checked).
# Broken test because tests.rs is not in crate sed -i '/#[cfg(test)]/,/mod tests/d' src/descriptor/mod.rs
This is unfortunate, but likely not avoidable.
I usually recommend to upstream projects to at least include all the files to make tests *compile* (if not run). If tests at least *compile* you can "--skip" as appropriate. But if they don't even compile, it's a lot more annoying.