Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libitl - Libraries for The Islamic Tools and Libraries Project
https://bugzilla.redhat.com/show_bug.cgi?id=431181
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED Flag|fedora-review?, |fedora-review+ |needinfo?(tibbs@math.uh.edu)|
------- Additional Comments From tibbs@math.uh.edu 2008-02-11 15:24 EST ------- Aargh, setting needinfo made this drop out of my TODO list and I missed it when I was going over my tickets this weekend. I really wish needinfo worked better.
Anyway, the new package looks better, but there's a problem with the avoidance of autoconf.
First off, if you're going to provide a built configure file, please just supply it as Souce1: instead of patching it in. A patch that does nothing more than add a source file is rather strange.
But honestly, I'm not really sure that patching in the configure file is any better than just generating it. It has the benefit of not requiring the autotools and not being dependent on the specific autotools versions that might be installed on each release you're building on, so I guess it's no worse. Frankly I'm not really sure which is the right thing to do, but I've held this ticket up long enough thinking about the issue.
So I'll go ahead and approve this, but please move the new configure file to a source file instead of a patch before you check things in.
APPROVED