Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=666301
Volker Fröhlich volker27@gmx.at changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |volker27@gmx.at
--- Comment #4 from Volker Fröhlich volker27@gmx.at 2010-12-31 19:47:37 EST --- A few things I noticed:
The verbose flag for make is not necessary, because CMAKE_VERBOSE_MAKEFILE is already set to "on", when you're using %cmake. See http://www.vtk.org/Wiki/CMake_FAQ#Is_there_an_option_to_produce_more_.27verb... and rpm -E %cmake
Please give a rationale in the spec why you're deleting $RPMBUILD/usr/share.
The chmod seems unnecessary, since all files in $RPMBUILD/usr/bin are already 755.
I think there are some tests and Python bindings as well, is that correct?