Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=688183
Elder Marco eldermarco@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |eldermarco@gmail.com
--- Comment #14 from Elder Marco eldermarco@gmail.com 2011-07-01 19:34:54 EDT --- Hi,
Just a few comments.
- It's a good idea to add each dependencies on a single line. It's more readable. In this case:
BuildRequires: gtk2-devel BuildRequires: gstreamer-devel BuildRequires: libnotify-devel BuildRequires: desktop-file-utils
- The strings in source code is in Japanese/Chinese .. I don't know, but this is a problem.
- In Source0 field, you could use: Source0: http://iceplayer.googlecode.com/files/%%7Bname%7D-src-%%7Bversion%7D-%%7Bdat...
- Use %{?_smp_mflags} instead of %{_smp_mflags}.
- In %files section, add the files NEWS THANKS in %doc. - For the files, you could use: %{_bindir}/%{name} %{_datadir}/applications/%{name}.desktop %dir %{_datadir}/%{name}/ %{_datadir}/%{name}/*