Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=592670
Chen Lei supercyper1@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |supercyper1@gmail.com
--- Comment #1 from Chen Lei supercyper1@gmail.com 2010-05-16 23:32:11 EDT --- Several problems:
1. missing a initscript http://fedoraproject.org/wiki/Packaging:SysVInitScript
2.-devel subpackage is not needed in this package
3. %doc %{_defaultdocdir}/%{name}-%{version}/%{name}.conf
%doc is not needed in %{_defaultdocdir}
4.
Group: Development/Tools is not appropriate
5.Please do not gzip man page by yourself, rpmbuild will do it automatically.
6. most packagers/reviewers don't like use unnecessary macros, e.g. %{__install} %{__gzip}
Some reference for you: 1.http://fedoraproject.org/wiki/How_to_create_an_RPM_package 2.http://fedoraproject.org/wiki/PackagingGuidelines