[Bug 2158742] Review Request: perl-Feature-Compat-Try - Make try/catch syntax available

https://bugzilla.redhat.com/show_bug.cgi?id=2158742

--- Comment #2 from Petr Pisar  ---
TODO: Change URL to https://metacpan.org/dist/Feature-Compat-Try which
pertains the whole CPAN distribution. The one in the spec file is a
documentation for a particular module.
Source archive is original (SHA-512:
bf2c87bc29509e902ea4e27a22162efc58e93452a06483a19e17b70ee6db3e2407494209708dc84f2ef9080a91c374870de100cc42038683a4ae7891b07ab683).
Ok.
Summary verified from lib/Feature/Compat/Try.pm. Ok.
Description verified from lib/Feature/Compat/Try.pm. Ok.

'GPL-1.0-or-later OR Artistic-1.0-Perl' license found in:
lib/Feature/Compat/Try.pm, LICENSE, Build.PL.
FIX: Correct a License RPM tag to 'GPL-1.0-or-later OR Artistic-1.0-Perl'.
'Perl' is not a recognized identifier
https://docs.fedoraproject.org/en-US/legal/license-field/#_perl_packages.

No XS code, noarch BuildArch is Ok.

FIX: Build-require 'coreutils' (perl-Feature-Compat-Try.spec:42).
FIX: Build-require 'perl(:VERSION) >= 5.14' (lib/Feature/Compat/Try.pm:8).
TODO: Constrain 'perl(Syntax::Keyword::Try)' dependency with '>= 0.27'
(Build.PL:10).
TODO: Constrain 'perl(Test::More)' dependency with '>= 0.88' (Build.PL:29).
TODO: Constrain 'perl(Future::AsyncAwait)' dependency with '>= 0.10'
(t/80await+try.t:12).

Test::Pod is optional (t/99pod.t:8). Ok.

TODO: List files under %{perl_vendorlib} directory explicitly. Globing all
files (*) is not recommended (perl-Feature-Compat-Try.spec:52)
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists.

All tests pass. Ok.

$ rpmlint perl-Feature-Compat-Try.spec
../SRPMS/perl-Feature-Compat-Try-0.05-1.fc38.src.rpm
../RPMS/noarch/perl-Feature-Compat-Try-0.05-1.fc38.noarch.rpm 
======================================== rpmlint session starts
=======================================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 3

perl-Feature-Compat-Try.noarch: W: invalid-license Perl
perl-Feature-Compat-Try.src: W: invalid-license Perl
========= 2 packages and 1 specfiles checked; 0 errors, 2 warnings, 0 badness;
has taken 0.4 s ========
FIX: Correct the license value.

$ rpm -q -lv -p ../RPMS/noarch/perl-Feature-Compat-Try-0.05-1.fc38.noarch.rpm 
drwxr-xr-x    2 root     root                        0 Jan  6 01:00
/usr/share/doc/perl-Feature-Compat-Try
-rw-r--r--    1 root     root                      934 Feb 20  2022
/usr/share/doc/perl-Feature-Compat-Try/Changes
-rw-r--r--    1 root     root                     6499 Feb 20  2022
/usr/share/doc/perl-Feature-Compat-Try/README
drwxr-xr-x    2 root     root                        0 Jan  6 01:00
/usr/share/licenses/perl-Feature-Compat-Try
-rw-r--r--    1 root     root                    18413 Feb 20  2022
/usr/share/licenses/perl-Feature-Compat-Try/LICENSE
-rw-r--r--    1 root     root                     3566 Jan  6 01:00
/usr/share/man/man3/Feature::Compat::Try.3pm.gz
drwxr-xr-x    2 root     root                        0 Jan  6 01:00
/usr/share/perl5/vendor_perl/Feature
drwxr-xr-x    2 root     root                        0 Jan  6 01:00
/usr/share/perl5/vendor_perl/Feature/Compat
-rw-r--r--    1 root     root                     6984 Jan  6 01:00
/usr/share/perl5/vendor_perl/Feature/Compat/Try.pm
File layout and permissions are Ok.

$ rpm -q --requires -p
../RPMS/noarch/perl-Feature-Compat-Try-0.05-1.fc38.noarch.rpm | sort -f | uniq
-c
      1 perl(:MODULE_COMPAT_5.36.0)
      1 perl(:VERSION) >= 5.14.0
      1 perl(constant)
      1 perl(feature)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsZstd) <= 5.4.18-1
TODO: Syntax::Keyword::Try is only used with perls < 5.35.8
(lib/Feature/Compat/Try.pm:13). That's available since Fedora 37. If you want
to support older Fedoras or EPELs, please conditionally run-require
'perl(Syntax::Keyword::Try) >= 0.27' on those distributions.

$ rpm -q --provides -p
../RPMS/noarch/perl-Feature-Compat-Try-0.05-1.fc38.noarch.rpm | sort -f | uniq
-c
      1 perl(Feature::Compat::Try) = 0.05
      1 perl-Feature-Compat-Try = 0.05-1.fc38
Binary provides are Ok.

$ resolvedeps rawhide
../RPMS/noarch/perl-Feature-Compat-Try-0.05-1.fc38.noarch.rpm 
Binary dependencies are resolvable. Ok.

The package builds in Fedora 38
(https://koji.fedoraproject.org/koji/taskinfo?taskID=95805716). Ok.

Otherwise, the package is in line with Fedora and Perl packaging guidelines.
Please correct 'FIX' items, consider fixing 'TODO' items, and provide a new
spec file.
Resolution: Package NOT approved.