Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=784857
--- Comment #3 from Bohuslav Kabrda bkabrda@redhat.com 2012-01-27 01:54:49 EST --- (In reply to comment #2)
- Version in patch name is questionable
- If the patch is not accepted by upstream for next release, you will need either to rename the patch or remove the %{version} macro anyway, so I would suggest to not use macro in this case
True, done.
The test suite should not be carried by resulting gem
Although I appreciate that you are executing test suite, I suggest its unpacking just in %check section, which prevents its inclusion in resulting package.
%check tar xzvf %{SOURCE1} -C .%{geminstdir}
Done.
- MiniTest instead of TestUnit
- Have you considered using Minitest, which is now default in Ruby, instead
of test-unit?
Yes, tests work the same way with minitest, so I switched to it.
rpmlint
Please fix following rpmlint error:
rubygem-openstack-compute.noarch: E: non-executable-script \ /usr/share/gems/gems/openstack-compute-1.1.5/lib/openstack/compute.rb \ 0664L /usr/bin/env
Fixed.
SPEC: http://bkabrda.fedorapeople.org/pkgs/openstack-compute/rubygem-openstack-com... SRPM: http://bkabrda.fedorapeople.org/pkgs/openstack-compute/rubygem-openstack-com... Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3738691