Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: Mapnik cartography library - first package, need sponsor.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234581
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-07-06 14:48 EST ------- Created an attachment (id=158690) --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=158690&action=vie...) mock build log of mapnik 0.4.0-4 on rawhide i386
Very quick comment:
! Details are written in http://fedoraproject.org/wiki/Packaging/Guidelines http://fedoraproject.org/wiki/Packaging/ReviewGuidelines
* rpmlint: ---------------------------------------------------- W: mapnik wrong-file-end-of-line-encoding /usr/share/doc/mapnik-0.4.0/demo/data/boundaries_l.shp.xml W: mapnik wrong-file-end-of-line-encoding /usr/share/doc/mapnik-0.4.0/demo/data/boundaries.shp.xml W: mapnik wrong-file-end-of-line-encoding /usr/share/doc/mapnik-0.4.0/demo/data/qcdrainage.shp.xml W: mapnik wrong-file-end-of-line-encoding /usr/share/doc/mapnik-0.4.0/demo/data/ontdrainage.shp.xml W: mapnik wrong-file-end-of-line-encoding /usr/share/doc/mapnik-0.4.0/demo/data/popplaces.shp.xml W: mapnik wrong-file-end-of-line-encoding /usr/share/doc/mapnik-0.4.0/demo/data/COPYRIGHT.txt W: mapnik wrong-file-end-of-line-encoding /usr/share/doc/mapnik-0.4.0/demo/data/roads.shp.xml W: mapnik summary-ended-with-dot Library providing algorithms for spatial data access and visualization. E: mapnik invalid-soname /usr/lib/libmapnik.so libmapnik.so W: mapnik summary-ended-with-dot Library providing algorithms for spatial data access and visualization. W: mapnik rpm-buildroot-usage %build scons PREFIX=%{_prefix} DESTDIR=%{buildroot} %{?_smp_mflags} W: mapnik macro-in-%changelog _prefix ----------------------------------------------------------------- SUMMARY: - Some files have Windows-style end-of-file encodings. Please fix them to Unix-style encodings - Summary should not end with dot. ? QUESTION How is libmapnik.so used? - Is this library used only by this package? - Or can this library be linked from other software? - In %changelog, please use %%_prefix. Otherwise %_prefix is expanded in %changelog.
* compilation flags - Fedora specific compilation flags are not honored. - -O3 flag is generally forbidden (this make debugging difficult)
* Fonts - Fedora has dejavu-fonts, dejavu-fonts-experimental and shipping duplicate dejavu fonts in this package is not allowed.
* sitelib vs sitearch - This package installs /usr/lib/python2.5/site-packages/mapnik/_mapnik.so , which is arch dependent. python related files must be installed under %python_sitearch. not under %python_sitelib. http://fedoraproject.org/wiki/Packaging/Python