https://bugzilla.redhat.com/show_bug.cgi?id=2297189
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |decathorpe@gmail.com Flags| |fedora-review?
--- Comment #4 from Fabio Valentini decathorpe@gmail.com --- Taking this review.
There's some things that need to be addressed, but they're inter-related.
You left some FIXME items generated by rust2rpm in the spec file without ... fixing them:
# FIXME: paste output of %%cargo_license_summary here License: # FIXME
Incidentally, it looks like that "test_lints" executable only serves some test purpose, and probably shouldn't even be shipped as a package in Fedora.
You can prevent generation of this subpackage with a rust2rpm.toml config file like this:
``` [package] cargo-install-bin = false ```