https://bugzilla.redhat.com/show_bug.cgi?id=1651962
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@gmail.com
--- Comment #2 from Robert-André Mauchin zebob.m@gmail.com --- - Add comments explaining what the patches do
- There doesn't seem to be a version 4.0, the latest is 3.5 dev branch
- Shouln't it be %patch0 and %patch1 here
%if 0%{?fedora} >=29 %patch -P 1 -p1 %else %patch -P 0 -p1 %endif
- Not needed anymore:
%post /bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null || :
%postun if [ $1 -eq 0 ] ; then /bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null /usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : fi
%posttrans /usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :
- You copy the translation in the main package with %files -f %{name}.lang but own the directories in the data subpackage, this is not logical.
- Why don't you use %find_lang???
find %{buildroot}%{_datadir}/%{name}/translations -name "*.qm" | sed 's:'%{buildroot}':: s:.*/([a-zA-Z]{2}).qm:%lang(\1) \0:' > %{name}.lang