Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=498136
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #8 from Kevin Fenzi kevin@tummy.com 2009-05-03 23:16:37 EDT --- Andreas: Sorry for hijacking here, but we really need to have this review done. I hope you don't mind I take over?
OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 3d519bc7d812aed8f6e4288b6d3cdf26 gnome-media-2.26.0.tar.bz2 3d519bc7d812aed8f6e4288b6d3cdf26 gnome-media-2.26.0.tar.bz2.orig OK - Package needs ExcludeArch OK - BuildRequires correct OK - Spec handles locales/find_lang OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install
OK - Package is a GUI app and has a .desktop file
OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) See below - No rpmlint output. OK - final provides and requires are sane.
SHOULD Items:
OK - Should build in mock. OK - Should have sane scriptlets. OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin
Issues:
1. Should the Requires: gnome-media be versioned? Or will it cause any issue for this to be out of step with gnome-media? I suspect not, but though I would mention it.
2. rpmlint says:
gst-mixer.src:163: W: macro-in-%changelog defines
Minor issue... change to %%defines in changelog? :)
gst-mixer.x86_64: W: non-conffile-in-etc /etc/gconf/schemas/gst-mixer.schemas
Can be ignored.
I don't see any blockers here, so this package is APPROVED.
Fix the %%define and address if gnome-media requires should be versioned before import?