Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: plotmm
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193109
rc040203@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: plotmm |Review Request: plotmm AssignedTo|bugzilla-sink@leemhuis.info |rc040203@freenet.de OtherBugsDependingO|163776 |163778 nThis| |
------- Additional Comments From rc040203@freenet.de 2006-05-26 00:02 EST ------- NEEDSWORK:
Blockers:
- The package ships example applications in %{_bindir} /usr/bin/simple /usr/bin/curve
To me this seems questionable twice: 1. These application names are too general and likely to conflict with other packages. 2. Installing example applications to %{_bindir} isn't necessarily a wise decision.
Wrt. 2, I'd propose to move these examples out of the base package into an *-examples package or to make them part of the *-devel package.
Wrt. 1., I'd propose to move these applications out of %{_bindir} and to install them into a different location (e.g. %{_libdir}/plotmm/examples), or to rename them into something less likely to conflict (e.g. plotmm-{simple|curve}).
Minor: - The sources contain devel docs (in doc/html/), but they are not being packages. I'd propose to ship these docs as part of the *-devel package
- Rpmlint complaints:
# rpmlint plotmm-0.1.2-1.i386.rpm W: plotmm summary-ended-with-dot GTKmm plot widget for scientific applications. E: plotmm description-line-too-long It contains widgets which are primarily useful for technical and scientifical purposes. E: plotmm zero-length /usr/share/doc/plotmm-0.1.2/NEWS E: plotmm zero-length /usr/share/doc/plotmm-0.1.2/INSTALL
# rpmlint plotmm-devel-0.1.2-1.i386.rpm W: plotmm-devel summary-ended-with-dot Headers for developing programs that will use plotmm. E: plotmm-devel description-line-too-long This package contains the headers that programmers will need to develop applications which will use plotmm. W: plotmm-devel no-documentation
General issue: You are using an Alias-name instead of your real name in %changelog. I am opposed to this practice.