[Bug 1671571] Review Request: playerctl - MPRIS command-line controller and library for spotify, vlc, audacious, bmp, cmus, and others

https://bugzilla.redhat.com/show_bug.cgi?id=1671571

Dridi Boukelmoune  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]

--- Comment #4 from Dridi Boukelmoune  ---
More changes for playerctl:

--- playerctl.spec  2019-02-04 09:21:17.102143219 +0100
    +++ playerctl.spec  2019-02-04 09:24:00.415760142 +0100
    @@ -5,7 +5,7 @@

License:        LGPLv3+
     URL:            https://github.com/acrisci/playerctl
    -Source0:        %{url}/archive/v%{version}/%{name}-%{version}.tar.gz
    +Source:        
%{url}/releases/download/v%{version}/%{name}-%{version}.tar.xz

BuildRequires:  gcc
     BuildRequires:  meson
    @@ -62,13 +62,15 @@
     %{_bindir}/%{name}
     %{_datadir}/gir-1.0/Playerctl-2.0.gir
     %{_libdir}/girepository-1.0/Playerctl-2.0.typelib
    -%{_libdir}/lib%{name}.*
    -%doc %{_datadir}/gtk-doc/html/%{name}/*
    -%doc %{_datadir}/man/man1/%{name}.*
    +%{_libdir}/lib%{name}.so.2*
    +%{_datadir}/gtk-doc/html/%{name}
    +%{_datadir}/man/man1/%{name}.*

%files devel
     %{_includedir}/%{name}/*.h
    +%{_libdir}/lib%{name}.a
    +%{_libdir}/lib%{name}.so
     %{_libdir}/pkgconfig/%{name}.pc

The xz archive is handled just fine, and you should file a bug for COPR if it's
not working there. We are targeting Fedora proper here so I'd rather stick to
the upstream release archive.

I also moved the static library and un-versioned shared object to the devel
packages, and added the full soname in the main package so we don't miss soname
bumps in the future. I built this with mock locally and I'm currently using the
package on my system with no regression.

Finally, I removed the %doc indicators because those are well-known locations
in Fedora so they already get flagged as such, and I made sure the
%{_datadir}/gtk-doc/html/%{name} is owned by the package, not just its
contents.

When you update the spec, make sure to add a new comment with corresponding
Spec and SRPM URLs so that during the formal review fedora-review picks up your
latest update (especially since you updated the release tag, that changes the
SRPM URL).

Good luck with your sponsorship, I will patiently wait :)