Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dwarves - DWARF Tools
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234667
ajackson@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |ajackson@redhat.com
------- Additional Comments From ajackson@redhat.com 2007-05-11 22:41 EST ------- As of 0-24:
% rpmlint i386/*.rpm W: dwarves no-version-in-last-changelog E: dwarves only-non-binary-in-usr-lib W: dwarves devel-file-in-non-devel-package /usr/lib/ctracer/ctracer_relay.c W: dwarves devel-file-in-non-devel-package /usr/lib/ctracer/ctracer_relay.h W: dwarves devel-file-in-non-devel-package /usr/lib/ctracer/ctracer_jprobe.c W: dwarves-debuginfo no-version-in-last-changelog W: libdwarves1 no-version-in-last-changelog W: libdwarves1 no-documentation W: libdwarves1-devel no-version-in-last-changelog
The one error is unpleasant. Any reason why that stuff's not in /usr/share? systemtap has similar code in its directories in /usr/share, so even though it technically violates one of the MUSTS in the review guidelines I think there's a good case for it.
Also, if the SRPM is intended to be the preferred distribution format, then you need to note that in a comment above Source0.
Otherwise passes all MUSTS as far as I can see.