https://bugzilla.redhat.com/show_bug.cgi?id=1459693
Carl George carl.george@rackspace.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(carl.george@racks | |pace.com) |
--- Comment #3 from Carl George carl.george@rackspace.com ---
[!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* GPL (v2 or later) (with incorrect FSF address)", "Unknown or generated", "*No copyright* GPL". 13 files have unknown license. Detailed output of licensecheck in /home/ctrianta/1459693-recap/licensecheck.txt Can you please raise a ticket to the upstream to correct the FSF address in src/recaptool.8? Also adding a copyright message in the beginning of each file is recommended (13 files are reported with no license)
Done and merged.
https://github.com/rackerlabs/recap/pull/95
[x]: Package must own all directories that it creates. Note: Directories without known owners: /etc/cron.d
Added a requirement of crontabs, per https://fedoraproject.org/wiki/Packaging:CronFiles.
[!]: Package consistently uses macros (instead of hard-coded directory names). Can you please replace "recap" with %{name} in the %files section.
This is not really necessary.
[!]: Requires correct, justified where necessary. Is there a reason we have the following requirements: bash coreutils gawk grep procps/procps-ng The seem to be on the base installation anyway.
I'll remove bash, coreutils, gawk, and grep since they appear to always be installed, even on minimal docker images. I have seen instances where procps(-ng) wasn't installed, so I'll keep that one.
[!] Can you please document the reason for the non-standard-dir-perm on /var/log/recap folders? My understanding is to protect logs that include output that normally only root can see.
Upstream sets these to 750 in the Makefile. I believe you are correct that the original intent was for logs to only be viewable by root. I've opened an issue upstream to discuss possibly changing it.
https://github.com/rackerlabs/recap/issues/98
[!] How are the files in the /var/log/recap folder rotated? What prevents them from filling the disk?
Recap implements it's own custom log rotation. https://github.com/rackerlabs/recap/blob/1.0.0/CHANGELOG.md#097---2013-10-31