Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ldm - LTSP Display Manager
https://bugzilla.redhat.com/show_bug.cgi?id=428586
a.badger@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
------- Additional Comments From a.badger@gmail.com 2008-01-17 09:23 EST ------- APPROVED
Looks good. I changed the README to reflect your changes to libexecdir and pushed upstream.
Only one thing left to be fixed in the spec file:
* Need to have checkout instructions for getting the source for revision control: http://fedoraproject.org/wiki/Packaging/SourceURL
For instance::
# bzr snapshot:: # bzr checkout --lightweight -r 791 http://bazaar.launchpad.net/~ltsp-upstream/ltsp/ldm-trunk # cd ldm-trunk # ./mkdst --test # tarball is ldm-%{version}.tar.bz2
Fix this when you checkin and this package is approved.
Note: I also notice that gcc is throwing several valid warnings. I'm attaching a patch for you to review that fixes most of them. I didn't fix any of the:: "warning: ignoring return value of ‘write’, declared with attribute warn_unused_result"
because I'm not sure how you want to deal with those.