Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: authd
https://bugzilla.redhat.com/show_bug.cgi?id=225294
------- Additional Comments From jsafrane@redhat.com 2008-02-13 05:02 EST ------- (In reply to comment #1)
rpmlint on srpm:
authd.src:7: W: unversioned-explicit-obsoletes pidentd
Fixed
authd.src:18: W: prereq-use xinetd
Fixed
authd.src: W: no-url-tag
See below
authd.i386: E: non-readable /etc/ident.key 0640
That's an intention, it's secret password.
authd.i386: E: zero-length /etc/ident.key
That's an intention, it's zero-length secret password.
authd.i386: W: conffile-without-noreplace-flag /etc/ident.key
That's an intention, do not overwrite the password.
These are OK.
authd.i386: W: dangerous-command-in-%post chown Fix if possible, might want to use the full path to chown.
Chown is needed, and there *is* full path to /bin/chown.
In addition to needing a URL tag, the Source tag needs a url pointing to the upstream tarball. If Fedora or RH are upstream, get a space on hosted.
I did not find any upstream of authd, did I miss something? If there is not any, I'll go to fedorahosted.org
License tag should be GPLv2+.
Fixed
Error in rawhide mock build:
Fixed
Other than that, looks good, no other blockers.
Thanks for the review!
After the fixes (authd-1.4.3-14.rpm), rpmlint complains about: authd.i386: E: non-readable /etc/ident.key 0640 authd.i386: E: zero-length /etc/ident.key authd.i386: W: no-url-tag authd.i386: W: conffile-without-noreplace-flag /etc/ident.key authd.i386: W: dangerous-command-in-%post chown authd.src: W: no-url-tag authd-debuginfo.i386: W: no-url-tag
All these errors except url are described above.