Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=689815
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #3 from Petr Pisar ppisar@redhat.com 2011-05-13 09:41:18 EDT --- Spec file changes:
--- perl-MooseX-Role-TraitConstructor.spec 2011-03-22 15:17:00.000000000 +0100 +++ perl-MooseX-Role-TraitConstructor.spec.1 2011-05-13 15:02:14.000000000 +0200 @@ -17,10 +17,7 @@ BuildRequires: perl(Test::More) BuildRequires: perl(Test::use::ok) BuildRequires: perl(warnings) -Requires: perl(List::Util) Requires: perl(Moose) >= 0.40 -Requires: perl(Test::Exception) -Requires: perl(Test::use::ok) Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
%{?perl_default_filter} @@ -49,8 +46,6 @@ make test
%files -%defattr(-,root,root,-) -%doc %{perl_vendorlib}/* %{_mandir}/man3/*
FIX: Remove useless Requires: perl(Test::Exception)
-Requires: perl(Test::Exception) Ok.
Fix: Remove useless Requires: perl(Test::use::ok)
-Requires: perl(Test::use::ok) Ok.
TODO: Remove useless %defattr and %doc macros from %files section
-%defattr(-,root,root,-) -%doc Ok.
TODO: Remove explicit Requires for auto-discovered perl(List::Util)
-Requires: perl(List::Util) Ok.
$ rpm -q --requires -p ../RPMS/noarch/perl-MooseX-Role-TraitConstructor-0.01-1.fc14.noarch.rpm | sort | uniq -c 1 perl(constant) 1 perl(List::Util) 1 perl(:MODULE_COMPAT_5.12.3) 1 perl(Moose::Role) 1 perl(Moose) >= 0.40 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 2 rpmlib(VersionedDependencies) <= 3.0.3-1 Binary requires Ok.
$ resolvedeps dist-f16 ../RPMS/noarch/perl-MooseX-Role-TraitConstructor-0.01-1.fc14.noarch.rpm Binary dependencies resolvable. Ok.
Resolution: Package APPROVED.