https://bugzilla.redhat.com/show_bug.cgi?id=1372866
--- Comment #38 from Jason Taylor jtfas90@gmail.com --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #36)
One more nitpick: I suggested:
https://github.com/01org/hyperscan/archive/%%7Bversion%7D.tar.gz#/hyperscan-...
That doesn't work, because I forgot a "v". It should have been https://github.com/01org/hyperscan/archive/v%%7Bversion%7D.tar.gz#/hyperscan... %{version}.tar.gz
You used:
https://github.com/01org/%%7Bname%7D/archive/%%7Bgittag0%7D.tar.gz#/%%7Bname...
That works, but it uses both gittag0 and version. That is suboptimal because you need to change both gittag0 and version when updating version. What's worse, if you forget one, you'll get a mismatched tarball name and contents. So I'd suggest using %{version} or "v%{version}" everywhere instead of %{gittag0} and removing %gittag0 definition completely.
I fixed this in the release version as you suggested. Thanks again!