Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=509310
--- Comment #15 from Christian Krause chkr@plauener.de 2009-09-22 18:03:16 EDT --- Thanks for the new package. Please see my comments below:
(In reply to comment #14)
Spec URL: http://giallu.fedorapeople.org/gpointing-device-settings.spec SRPM URL: http://giallu.fedorapeople.org/gpointing-device-settings-1.3.1-3.fc11.src.rp...
Somehow the spec file differs from the spec file inside the src.rpm. I looks like that the standalone spec file contains some more fixes. Please make sure that both match in the next update. ;-)
(In reply to comment #11)
IMHO having just two packages: gpointing-device-settings and gpointing-device-settings-devel would be better.
DONE
Ok, good.
- pkgconfig file: TODO
- The pkgconfig file contains the following linker flags:
Libs: -L${libdir} -lgpointing-device-settings which won't work at all, since the library's name is "libgpds.so". Please substitute the line with something like this: Libs: -L${libdir} -lgpds
DONE
Ok.
- GUI applications must provide *.desktop file: TODO
I'm quite sure that the gpointing-device-settings is the regular configuration dialog for the user to setup his mouse/touchpad preferences. Similar as it was done in the gsynaptics package it must be available in the Preferences menu: e.g. in System -> Preferences -> Pointing Device Settings Please add the according .desktop file.
DONE (.desktop file adapted from gsynaptic)
Unfortunately there is an icon referenced ("touchpad") which was only provided by the gsynaptic package and so it is missing in the menu entry. Probably we can use either another icon provided by one of the base packages or we can add the icon from the gsynaptic package as a separate source to this package.
Additionally desktop-file-validate complains about some problems: desktop-file-validate /usr/share/applications/gpointing-device-settings.desktop /usr/share/applications/gpointing-device-settings.desktop: warning: key "Encoding" in group "Desktop Entry" is deprecated /usr/share/applications/gpointing-device-settings.desktop: warning: value "GNOME;Application;Settings;" for key "Categories" in group "Desktop Entry" contains a deprecated value "Application"
- Obsoletes: TODO
- Obsoletes: the version must be greater than the version of the current
package, otherwise the current gsynaptics pacakge would not be obsoleted Obsoletes: gsynaptics < 0.9.16-2
DONE
You have used: Obsoletes: gsynaptics <= 0.9.17 IMHO this should be: Obsoletes: gsynaptics < 0.9.17 ( http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Renaming.2Freplacin... )
- Scriptlets: TODO
- gconf: please adjust the GConf scriptlets according to
http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#GConf
DONE
OK.
The package looks now quite good and there are only some very minor issues left.