https://bugzilla.redhat.com/show_bug.cgi?id=2232847
--- Comment #5 from Robin Lee robinlee.sysu@gmail.com --- (In reply to Felix Wang from comment #4)
Take this. Besides the above Tim's comments, Here are my comments.
- It would be better to put the files in the -devel sub-package, like the
wayland-protocols package, https://src.fedoraproject.org/rpms/wayland-protocols/blob/rawhide/f/wayland- protocols.spec
Done.
The %{name}-devel package contains libraries and header files for developing applications that use %{name}.
The description is not appropriate to express the package.
Done. The description is updated.
BuildRequires: qt5-qtbase-devel
I see the CMake files in the project, it seems that the package do not have this build dependency.
Done. BR on qt5-qtbase-devel is dropped.