Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=574267
Steve Traylen steve.traylen@cern.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |steve.traylen@cern.ch Flag| |fedora-review?
--- Comment #5 from Steve Traylen steve.traylen@cern.ch 2010-03-31 16:20:46 EDT --- Thanks for the explanation this makes sense to me. As long as the package updates cleanly from perl's own to this one it is good.
Review: perl-Test-Simple Date: 31st March 2010 Mock Build: F14-x86_64 tested.
* COMMENT: rpmlint output $ rpmlint SPECS/perl-Test-Simple.spec RPMS/noarch/perl-Test-Simple-0.94-1.fc12.noarch.rpm SRPMS/perl-Test-Simple-0.94-1.fc12.src.rpm perl-Test-Simple.noarch: E: devel-dependency perl-devel perl-Test-Simple.noarch: W: spelling-error %description -l en_US perldoc -> periodic, Perl, perforce perl-Test-Simple.noarch: W: spelling-error %description -l en_US lifed -> filed, life, lied perl-Test-Simple.src: W: spelling-error %description -l en_US perldoc -> periodic, Perl, perforce perl-Test-Simple.src: W: spelling-error %description -l en_US lifed -> filed, life, lied
Is the word "lifed" as in this dual-lifed now establised? It's really not a word.
As for dependecy on perl-devel yes it comes from the main perl package I see. * PASS: Named according to the Package Naming Guidelines. * PASS: spec file name same as base package %{name}. * PASS: Packaging Guidelines. * PASS: Approved license in .spec file. As perl. * PASS: License on Source code. As perl * PASS: Include LICENSE file or similar if it exist. Does not exist * COMMENT: Written in American English. "lifed" * PASS: Spec file legible. * PASS: Included source must match upstream source. $ md5sum Test-Simple-0.94.tar.gz ../SOURCES/Test-Simple-0.94.tar.gz e4e09d8bf2cc73124152ba2c45c95b5b Test-Simple-0.94.tar.gz e4e09d8bf2cc73124152ba2c45c95b5b ../SOURCES/Test-Simple-0.94.tar.gz * PASS: Build on one architecture. * NOTCHECKED: Not building on an architecture must highlighted. * PASS: Build dependencies must be listed in BuildRequires. * PASS: Handle locales properly. None present * PASS: ldconfig must be called on shared libs. None present * PASS: No bundled copies of system libraries. None present * PASS: Package must state why relocatable if relocatable. Not Relocatable. * PASS: A package must own all directories that it creates Standard perl * PASS: No duplicate files in %files listings. None * PASS: Permissions on files must be set properly. %defattr * PASS: %clean section contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). * PASS: Each package must consistently use macros. * PASS: The package must contain code, or permissable content. * PASS: Large documentation files must go in a -doc subpackage. None present. * PASS: %doc must not affect the runtime of the application. * PASS: Header files must be in a -devel package. * PASS: Static libraries must be in a -static package. None present. * PASS: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' None present. * PASS: Then library files that end in .so None present. * PASS: devel packages must require the exact base package * PASS: No .la libtool archives * PASS: GUI apps should have %{name}.desktop file No Gui * PASS: No files or directories already owned by other packages. * PASS: %install must run rm -rf %{buildroot} (or $RPM_BUILD_ROOT). * PASS: All filenames in rpm packages must be valid UTF-8.
Summary:
Just the comment about "lifed".
APPROVED.