Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=732651
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #4 from Petr Pisar ppisar@redhat.com 2011-08-24 06:56:17 EDT --- Spec file changes:
--- sshpass.spec 2011-08-23 10:15:26.000000000 +0200 +++ sshpass.spec.1 2011-08-23 13:44:59.000000000 +0200 @@ -2,30 +2,30 @@ Name: sshpass Version: 1.05 Release: 1%{?dist} -License: GPLv2+ +License: GPLv2 Group: Applications/Internet -Url: http://sshpass.sourceforge.net +Url: http://sshpass.sourceforge.net/ Source0: http://downloads.sourceforge.net/sshpass/sshpass-%%7Bversion%7D.tar.gz
%description -Sshpass is a tool for non-interactively performing password authentication with -SSH's so called "interactive keyboard password authentication". Most user -should use SSH's more secure public key authentication instead. +Tool for non-interactively performing password authentication with so called +"interactive keyboard password authentication" of SSH. Most users should use +more secure public key authentication of SSH instead.
%prep %setup -q
%build %configure -make +make %{?_smp_mflags}
%install make DESTDIR=%{buildroot} install
%files -%defattr(-,root,root,-) -%{_datadir}/man/man1/sshpass.1.gz %{_bindir}/sshpass +%{_datadir}/man/man1/sshpass.1.gz +%doc AUTHORS ChangeLog NEWS
%changelog
TODO: Uppercase `ssh' in Summary if this tool works (or should work) with other SSH implementations providing SSH client under different name than `ssh'.
Uppercased
TODO: I cannot see the change.
FIXME: COPYING delivers GPLv2 and main.c states GPLv2+, but AUTHORS says GPLv2 only. Correct License tag or ask upstream for clarification.
-License: GPLv2+ +License: GPLv2 Ok.
TODO: Normalize home page URL. I.e. append slash.
-Url: http://sshpass.sourceforge.net +Url: http://sshpass.sourceforge.net/
TODO: Correct spelling in Description. Namely leading word `Sshpass' is name of the tool and the tool, package, and even project is called `sshpass'. You can remove the beginning completely (Sshpass is a) to obey orthographic rules. Remove the abbreviated possession "'s" from "SSH's" as it can be used only to possess to life entities. The `SSH' becomes attribute automatically per English syntax rules.
%description -Sshpass is a tool for non-interactively performing password authentication with -SSH's so called "interactive keyboard password authentication". Most user -should use SSH's more secure public key authentication instead. +Tool for non-interactively performing password authentication with so called +"interactive keyboard password authentication" of SSH. Most users should use +more secure public key authentication of SSH instead. Ok.
TODO: Add %{?_smp_mflags} argument to `make' command to utilize parallel building, if the Makefile is not broken. (I know there is only one source file now, but it can help if upstream decides to use more source files.)
-make +make %{?_smp_mflags} Ok.
TODO: Remove useless %defattr macro in %files section as this is implicit.
%files -%defattr(-,root,root,-) Ok.
FIX: Package as documentation (macro %doc) files: AUTHORS, ChangeLog, NEWS.
+%doc AUTHORS ChangeLog NEWS Ok.
TODO: You can use %{_mandir} instead of %{_datadir}/man in %files section.
$ rpmlint sshpass.spec ../SRPMS/sshpass-1.05-1.fc15.src.rpm ../RPMS/x86_64/sshpass-* sshpass.src: W: invalid-url URL: http://sshpass.sourceforge.net/ HTTP Error 403: Forbidden sshpass-debuginfo.x86_64: W: invalid-url URL: http://sshpass.sourceforge.net/ HTTP Error 403: Forbidden sshpass-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/sshpass-1.05/main.c 3 packages and 1 specfiles checked; 1 errors, 2 warnings.
rpmlint Ok.
$ rpm -q -lv -p ../RPMS/x86_64/sshpass-1.05-1.fc15.x86_64.rpm -rwxr-xr-x 1 root root 11192 srp 24 12:50 /usr/bin/sshpass drwxr-xr-x 2 root root 0 srp 24 12:50 /usr/share/doc/sshpass-1.05 -rw-r--r-- 1 root root 700 čec 22 2010 /usr/share/doc/sshpass-1.05/AUTHORS -rw-r--r-- 1 root root 1455 srp 6 09:02 /usr/share/doc/sshpass-1.05/ChangeLog -rw-r--r-- 1 root root 213 čec 22 2010 /usr/share/doc/sshpass-1.05/NEWS -rw-r--r-- 1 root root 2192 srp 24 12:50 /usr/share/man/man1/sshpass.1.gz
File layout and permission Ok.
Package builds in F17 (http://koji.fedoraproject.org/koji/taskinfo?taskID=3297981). Ok.
Package is in line with Fedora packaging guidelines.
Resolution: Package APPROVED.