https://bugzilla.redhat.com/show_bug.cgi?id=1263600
--- Comment #2 from Jan Holcapek holcapek@gmail.com --- (In reply to Petr Šabata from comment #1)
- The package doesn't even build in mock. Seriously?
Now it does. Sorry, didn't know of [1] till today.
[1] https://fedoraproject.org/wiki/Using_Mock_to_test_package_builds
- Missing some build deps:
- perl, called in the spec
- perl(IO::Handle), lib/Log/Log4perl/Appender/Socket/UNIX.pm:10
- perl(Log::Log4perl::Appender), lib/Log/Log4perl/Appender/Socket/UNIX.pm:5
- perl(Socket), lib/Log/Log4perl/Appender/Socket/UNIX.pm:11
- perl(strict), Build.PL:2
- perl(Test::More), t/1_load.t:16
- perl(warnings), Build.PL:2
Fixed. But honestly, I was trusting cpanspec to figure that out. How did you found about these build deps? (Well, I can simply look into and grep the code for use-es and require-s, but I guess this could be (semi)automated somehow?)
- Optional but recommended for build consistency:
- perl(Test::NoWarnings), t/1_load.t:8
Fixed.
- Missing a runtime dependency on Log::Log4perl::Appender; this won't get autodetected.
Fixed.
- Drop %defattr, it's no longer required.
Dropped.
- The Group tag is optional and can be dropped.
Dropped.
- License texts need to be packaged using the %license macro.
Fixed. Another news for me, thanks. However, rpmlint complains upon the rpm:
perl-Log-Log4perl-Appender-Socket-UNIX.noarch: E: incorrect-fsf-address /usr/share/licenses/perl-Log-Log4perl-Appender-Socket-UNIX/LICENSE
- Consider packaging the `examples' directory as documentation.
FIncluded.
- The README file is useless in this case. Drop it.
Dropped.
Spec URL: https://github.com/holcapek/perl-Log-Log4perl-Appender-Socket-UNIX/blob/mast... SRPM URL: https://github.com/holcapek/perl-Log-Log4perl-Appender-Socket-UNIX/raw/maste...