https://bugzilla.redhat.com/show_bug.cgi?id=2160771
--- Comment #6 from Neal Gompa ngompa13@gmail.com --- (In reply to Yaakov Selkowitz from comment #5)
(In reply to Neal Gompa from comment #4)
Initial spec review:
Source0: %{url}/archive/%{commit}/Flatseal-%{commit}.tar.gz
This has tags, so use those instead: "%{url}/archive/v%{version}/Flatseal-%{version}.tar.gz"
The packaging guidelines say otherwise, since git tags are not immutable:
https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ #_git_tags
It definitely does not say that. It only mentions screwiness with how Bitbucket works.
desktop-file-validate %{buildroot}%{_datadir}/applications/%{app_id}.desktop
appstream-util validate-relax --nonet %{buildroot}%{_datadir}/appdata/%{app_id}.appdata.xml
These should go into %check for clarity.
The guidelines allow either:
https://docs.fedoraproject.org/en-US/packaging-guidelines/ #_desktop_file_install_usage
https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/ #_app_data_validate_usage
I guess, though checks like this should be in %check...