https://bugzilla.redhat.com/show_bug.cgi?id=2354812
--- Comment #3 from Simone Caronni negativo17@gmail.com --- Some comments:
BuildRequires: libjpeg-turbo-devel BuildRequires: libpng-devel BuildRequires: libwebp-devel BuildRequires: mesa-libGL-devel BuildRequires: rapidjson-devel BuildRequires: SDL2-devel BuildRequires: meson BuildRequires: ninja-build
Meson looks for some of these dependencies using pkgconfig, so for those please update the build requirements to use the pkgconfig format. Example:
BuildRequires: pkgconfig(libturbojpeg) BuildRequires: pkgconfig(libpng) BuildRequires: pkgconfig(libwebp) BuildRequires: pkgconfig(sdl2)
# Modifications do not allow for use of packaged rapidjson # https://github.com/thorvg/thorvg/issues/3358 Provides: bundled(rapidjson)
I think this is just a leftover to remove, as you require rapidjson as BuildRequires and you are also removing src/loaders/lottie/rapidjson in the %prep section.
%global _description %{expand: [..] %description %_description
You can avoid using the macro, you are calling the block of description just once, it's more readable if you put the description under %description directly.
Otherwise looks good.