https://bugzilla.redhat.com/show_bug.cgi?id=1380540
--- Comment #3 from Christoph Junghans junghans@votca.org --- (In reply to Dridi Boukelmoune from comment #2)
[?]: License file installed when any subpackage combination is installed. Review note, it is not present in the devel subpackage.
Devel pulls in the main package, which has the license file.
[!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/votca Review note: it is provided by votca-csg-common which isn't a dependency of the votca-xtp-common subpackage. Consider adding a dependency or owning /usr/share/votca too. [?]: Package does not generate any conflict. [!]: Package requires other packages for directories it uses. Review note: see above, it's not the case for the common subpackage.
Add requirement on votca-csg-common, that should fix these issues.
[?]: Package functions as described. Review note: too big for me to test, relying on the github account and web site looking serious. [?]: Package should compile and build into binary rpms on all supported architectures.
I did another Koji build and it passed on all 4 archs, see http://koji.fedoraproject.org/koji/taskinfo?taskID=15927493
[?]: %check is present and all tests pass. Review note: I failed to find a test suite with a quick glance.
Yes, there is no test suite.
Rpmlint (debuginfo)
Checking: votca-xtp-debuginfo-1.4-0.1rc1.fc26.x86_64.rpm votca-xtp-debuginfo.x86_64: E: script-without-shebang /usr/src/debug/xtp-1.4_rc1/src/tools/xtp_kmc_run.cc 1 packages and 0 specfiles checked; 1 errors, 0 warnings.
Review note: it looks like a broken permission in the debuginfosubpackage.
Fixed.