[Bug 429202] Review Request: liblqr-1 - LiquidRescale library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: liblqr-1 - LiquidRescale library
https://bugzilla.redhat.com/show_bug.cgi?id=429202
------- Additional Comments From mtasaka(a)ioa.s.u-tokyo.ac.jp 2008-02-25 13:57 EST
-------
Created an attachment (id=295827)
--> (https://bugzilla.redhat.com/attachment.cgi?id=295827&action=view)
Patch for pkgconfig .pc file to remove unneeded directory
For 0.1.0-4:
3 issues
* undefined non-weak symbols
-----------------------------------------------------------------
[root@localhost liblqr-1]# rpmlint liblqr-1 liblqr-1-devel
liblqr-1.i386: W: undefined-non-weak-symbol /usr/lib/liblqr-1.so.0.0.0 g_free
liblqr-1.i386: W: undefined-non-weak-symbol /usr/lib/liblqr-1.so.0.0.0 sqrt
liblqr-1.i386: W: undefined-non-weak-symbol /usr/lib/liblqr-1.so.0.0.0 log
liblqr-1.i386: W: undefined-non-weak-symbol /usr/lib/liblqr-1.so.0.0.0 exp
liblqr-1.i386: W: undefined-non-weak-symbol /usr/lib/liblqr-1.so.0.0.0
g_try_malloc
liblqr-1.i386: W: undefined-non-weak-symbol /usr/lib/liblqr-1.so.0.0.0
g_try_malloc0
-----------------------------------------------------------------
- liblqr-1.so contains undefined non-weak symbols.
You can check this by $ ldd -r /usr/lib/liblqr-1.so.
As this library is to be used for linkage from other packages,
such symbols cannot be allowed because leaving such symbols
causes linkage failure.
The following fixes this issue:
------------------------------------------------------------------
%build
export LDFLAGS="`pkg-config --libs glib-2.0` -lm"
%configure
%{__make} %{?_smp_mflags}
------------------------------------------------------------------
* Unneeded libdir in .pc file
- On i386, /usr/lib/pkgconfig/lqr-1.pc contains the line:
------------------------------------------------------------------
10 Libs: -L${libdir}/lqr-1 -llqr-1
------------------------------------------------------------------
But no libraries are installed under %{_libdir}/lqr-1 so
-L${libdir}/lqr-1 is unneed. Please apply the patch attached.
* %buildroot v.s. $RPM_BUILD_ROOT
- Please choose one and don't use both.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.