https://bugzilla.redhat.com/show_bug.cgi?id=1608949
Olivier Lemasle o.lemasle@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |o.lemasle@gmail.com
--- Comment #3 from Olivier Lemasle o.lemasle@gmail.com --- Hello,
- I know you removed "BuildRequires: gcc" following the first review request. However, the package does not build anymore on Rawhide or Fedora30 without a build dependency to gcc. Furthermore, it is now requested by guidelines [1] to list a BuildRequires against gcc, gcc-c++ or clang for C/C++ projects.
- Your changelog entry has not the standard format: version number should be on the same line as the timestamp: * Wed Jul 18 2018 Ricardo Martinelli de Oliveira ricardo.martinelli.oliveira@gmail.com - 0.18.0 - Initial version
- Static executable: You removed "tini-static" following the first review request. This is indeed following Fedora Packaging guidelines [2]. However, Docker depends on a statically-linked "tini" binary. Currently, package "moby-engine" [3] builds and bundles its own "tini". I'd like to depend on your project instead of building a separate version of tini, to follow Fedora Packaging Guidelines. However, that would require having "tini-static" in this package.
Do you think it could be an exception to the guidelines, given that: - tini depends only on libc - package "moby-engine" currently already ships a statically linked version of "tini".
[1] https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/#_buildr... [2] https://docs.fedoraproject.org/en-US/packaging-guidelines/#_statically_linki... [3] https://apps.fedoraproject.org/packages/moby-engine/