https://bugzilla.redhat.com/show_bug.cgi?id=2325294
Sandro gui1ty@penguinpee.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #19 from Sandro gui1ty@penguinpee.nl --- Required changes have been implemented. One last thing:
Please move `Requires: fzf` from the main package to `python3-pyzfz` on import. It's the installable package requiring `fzf` not the source package. That's covered by `BuildRequires:`.
$ rpm -q --requires -p results/python3-pyfzf-0.3.1-1.fc43.noarch.rpm python(abi) = 3.13 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PartialHardlinkSets) <= 4.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsZstd) <= 5.4.18-1
This should list `fzf` as a dependency, but it doesn't because of above.
Otherwise the package looks good. APPROVED.