Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: pyabiword - Python bindings for libabiword
https://bugzilla.redhat.com/show_bug.cgi?id=456178
rnorwood@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review-
------- Additional Comments From rnorwood@redhat.com 2008-07-22 12:30 EST ------- $ rpmlint ~/rpmbuild/SRPMS/pyabiword-0.6.1-1.fc9.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
$ rpmlint /home/rnorwood/rpmbuild/RPMS/i386/pyabiword-0.6.1-1.fc9.i386.rpm pyabiword.i386: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings.
o AUTHORS and COPYING are good candidates for marking as %doc. (COPYING must be included). Also, the contents of the examples/ directory could be included.
o The source files don't include a license, which they should. The contents of the COPYING file (GPLv2) isn't enough to indicate the license. See: http://fedoraproject.org/wiki/Licensing/FAQ
o The 'Vendor' tag should not be used according to Fedora packaging guidelines. http://fedoraproject.org/wiki/Packaging/Guidelines
Everything else looks ok to me. Once the above issues are fixed, I can approve.