https://bugzilla.redhat.com/show_bug.cgi?id=2215420
--- Comment #2 from Orion Poplawski orion@nwra.com --- (In reply to Jos de Kloe from comment #1)
Hi Orion, thanks for working on this. Here are a first few remarks from a preliminary review.
Thanks for the comments.
Issues:
- If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/
Add BR on gcc-c++.
- The License field must be a valid SPDX expression. Note: Not a valid SPDX expression 'GPL-3.0+'. See: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 ==>probably should be: "GPL-3.0-or-later"
Fixed.
- Spec should use %global instead of %define unless justified Current version has "%define qt_version 5"
Fixed.
- there is no %check section in the spec file ==>actually it is also to me not clear how a tool like this could be
checked during the rpm build proces.
There are no tests to run.
- Related to this, I could not easily check if "the Package functions as
described". According to the x2go wiki website: https://wiki.x2go.org/doku.php/wiki:advanced:x2gokdrive:start using this tool requires to rename x2gokdriveclient to the default name nxproxy and x2gokdrive to the default name x2goagent. Is it reasonable to expect this manual installation step from the user? Or did I overlook something?
With current x2goclient, in the session preferences you can check "Run in X2GoKDrive (experimental)" and it will run x2gokdriveclient.
Spec URL: https://orion.fedorapeople.org/x2gokdriveclient.spec SRPM URL: https://orion.fedorapeople.org/x2gokdriveclient-0.0.0.1-2.fc40.src.rpm