https://bugzilla.redhat.com/show_bug.cgi?id=2161114
--- Comment #3 from Dominik 'Rathann' Mierzejewski dominik@greysector.net --- Scratch build in koji succeeded: https://koji.fedoraproject.org/koji/taskinfo?taskID=104433221 .
License tag must be corrected: License: GPL-3.0-or-later
licensecheck finds the following additional licenses: Apache-2.0: src/timeline/media/css/bootstrap.min.css GPL-2.0-or-later: images/Humanity/* MIT: src/timeline/media/css/ui-darkness/jquery-ui.theme.css src/timeline/media/js/angular-animate.min.js src/timeline/media/js/angular.min.js src/timeline/media/js/jquery.js src/timeline/media/js/jquery-ui.js CC-BY-SA-4.0: src/emojis/* public-domain: doc/youtube_directive.py
However, the doc/youtube_directive.py file doesn't seem to be included in the final package, so I think it can be skipped.
Please convert to using the pyproject_* macros if possible. %py3_build and %py3_install are old-style. This might let you drop some of the manual BuildRequires, too.
Please change -f to -v in the rm invocation below: rm -f %{buildroot}%{_prefix}/lib/mime/packages/openshot-qt It'll fail when it's no longer necessary and the maintainer will know they can remove it.
Please open an upstream issue for non-x86 support.
The %files section should be more explicit, because the globs resolve to just one file in most cases:
%{_bindir}/* should be %{_bindir}/openshot-qt
%{_datadir}/applications/*.desktop should be %{_datadir}/applications/org.openshot.OpenShot.desktop
%{_datadir}/icons/hicolor/*/*/* should be %{_datadir}/icons/hicolor/*/apps/openshot-qt.png %{_datadir}/icons/hicolor/scalable/apps/openshot-qt.svg %{_datadir}/icons/hicolor/scalable/mimetypes/openshot-qt-doc.svg
%{_datadir}/pixmaps/* should be %{_datadir}/pixmaps/openshot-qt.svg
%{_datadir}/mime/packages/* should be %{_datadir}/mime/packages/org.openshot.OpenShot.xml
%{_metainfodir}/*.appdata.xml should be %{_metainfodir}/org.openshot.OpenShot.appdata.xml
Using a macro for 'org.openshot.OpenShot' might be a good idea here.
%{python3_sitelib}/*egg-info will not be required if you use %pyproject_* macros.
rpmlint finds some issues: openshot.noarch: E: zero-length /usr/lib/python3.12/site-packages/openshot_qt/windows/views/timeline_mixins.py openshot.noarch: W: no-manual-page-for-binary openshot-qt and some duplicate files: openshot.noarch: E: files-duplicated-waste 1318606 openshot.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/openshot_qt/images/cache/2744.png /usr/lib/python3.12/site-packages/openshot_qt/images/cache/1F300.png:/usr/lib/python3.12/site-packages/openshot_qt/images/cache/1F3BC.png:/usr/lib/python3.12/site-packages/openshot_qt/images/cache/1F4A4.png:/usr/lib/python3.12/site-packages/openshot_qt/images/cache/1F4CE.png:/usr/lib/python3.12/site-packages/openshot_qt/images/cache/1F587.png ...
Other than that, the spec file is legible.