Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=439630
--- Comment #92 from Levente Farkas lfarkas@lfarkas.org 2010-03-09 17:12:58 EST --- not required: cd .. rm -rf %{buildroot} (in install)
don't use -p in install param
if you use mkdir -p %{buildroot}%{_javadir} why use a few lines later install -dm 755 %{buildroot}%{_libdir}/%{name} some place use install some place use cp... try to be consequent.
don't use "" line break so much. a 80 chars long lines is not too long, so most lines shouldn't have to break.